Note the .toString() on the end. Hen
On Thu, Mar 17, 2011 at 9:08 AM, Gary Gregory <garydgreg...@gmail.com> wrote: > Looking at: > > public static String right(CharSequence seq, int len) > > I wonder why it is not: > > public static CharSequence right(CharSequence seq, int len) > > You think that would break call sites is why. But when I look at the impl, > the last line is: > > return StringUtils.subSequence(seq, seq.length() - len).toString(); > > Where subSequence is typed to return a CharSequence. > > Does the compiler convert the CharSequence to a String? How does that even > compile? > > Gary > > On Thu, Mar 17, 2011 at 3:08 AM, Henri Yandell <flame...@gmail.com> wrote: >> >> On Tue, Mar 15, 2011 at 9:39 PM, Henri Yandell <flame...@gmail.com> wrote: >> >> > 4) Stephen urged that we revisit StringUtils to see what else can move >> > to CharSequence. >> > >> > 5) Stephen recommended that CharSequenceUtils move into StringUtils. >> > This seems fair, CharSequenceUtils is never going to get a lot of >> > methods unless we move half of StringUtils out and make it feel very >> > odd. [DONE]. >> >> So having done #5, and working on #4, I'm starting to come up with a >> bunch of methods that might make sense on CharSequenceUtils. >> >> Basically it's a set of methods on java.lang.String that are being >> implemented to support CharSequence. The first step is to check if the >> CharSequence is a String; if so then optimize and use the >> java.lang.String code. Otherwise use a basic implementation built on >> top of the CharSequence API. They're currently living at the end of >> the StringUtils class, but I'm leaning towards making them their own >> class. CharSequenceUtils, or is there a better name? >> >> I'd also appreciate feedback on the current changes in case it's felt >> I'm reaching too much to support CharSequence as an API; I'm 20 of 76 >> unique method names along :) >> >> Hen >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > > > -- > Thank you, > Gary > > http://garygregory.wordpress.com/ > http://garygregory.com/ > http://people.apache.org/~ggregory/ > http://twitter.com/GaryGregory > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
