On 09/27/2010 01:59 PM, sebb wrote:
On 27 September 2010 12:12, Mladen Turk<mt...@apache.org>  wrote:
On 09/27/2010 12:33 PM, sebb wrote:

On 27 September 2010 10:48, Mladen Turk<mt...@apache.org>    wrote:

Hi,


I plan to T&R Daemon 1.0.4 this week
There are couple of minor and one major (DAEMON-100)
fixes resolved in the SVN.


Comments?

It looks like the README instructions for building procrun on Windows
are wrong, as there are no .x86 files. Now fixed (I hope)

Also, the check against PROCESSOR_ARCHITECTURE does not work on my
system which defines it in lower-case (x86).


Right. The check similar to BUILD_CPU should be done in that
case to deal with possible upper/lower cases.

Or allow CPU to be in either case, and check CPU for both cases when
it is used to generate the required flags?
Might be simpler to implement.


Well CPU is used later on for various stuff so must be in upper case.
Sadly Microsoft nmake does't have something like toupper(str)
which would simplify the things by an order of magnitude :(

BTW, BUILD_CPU is not documented as a default in the Makefile header.


Should be trivial to document.


Regards
--
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to