Yeah, I will improve my commit message in the future BTW, i have closed JIRA issue SCXML-153
2010/7/16 Rahul Akolkar <rahul.akol...@gmail.com> > On Thu, Jul 15, 2010 at 11:02 PM, <gu...@apache.org> wrote: > > Author: guixl > > Date: Fri Jul 16 03:02:10 2010 > > New Revision: 964665 > > > > URL: http://svn.apache.org/viewvc?rev=964665&view=rev > > Log: > > add prefix "*.scxml" for document import file selection dialog > > > <snip/> > > In cases where commits can be matched to JIRA issues (looks like this > change is related to SCXML-153), its good to have the JIRA issue ID in > the commit message. That way, JIRA will pick these up and make them > available in the "Subversion Commits" tab for the issue. As an example > from earlier today, see r964493 [1], whose commit message mentions > SCXML-151, causing the revision to appear in this view of the issue > [2]. > > Ofcourse, once the code additions /changes are in for an issue, it > should be resolved in JIRA as well. > > -Rahul > > [1] http://svn.apache.org/viewvc?view=revision&revision=964493 > [2] > https://issues.apache.org/jira/browse/SCXML-151?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel > > > > Modified: > > > > commons/sandbox/gsoc/2010/scxml-eclipse/trunk/src/main/java/org.apache.commons.scxml.modeling.diagram/src/org/apache/commons/scxml/modeling/diagram/part/ModelingImportWizard.java > > > > Modified: > commons/sandbox/gsoc/2010/scxml-eclipse/trunk/src/main/java/org.apache.commons.scxml.modeling.diagram/src/org/apache/commons/scxml/modeling/diagram/part/ModelingImportWizard.java > > URL: > http://svn.apache.org/viewvc/commons/sandbox/gsoc/2010/scxml-eclipse/trunk/src/main/java/org.apache.commons.scxml.modeling.diagram/src/org/apache/commons/scxml/modeling/diagram/part/ModelingImportWizard.java?rev=964665&r1=964664&r2=964665&view=diff > > > ============================================================================== > > --- > commons/sandbox/gsoc/2010/scxml-eclipse/trunk/src/main/java/org.apache.commons.scxml.modeling.diagram/src/org/apache/commons/scxml/modeling/diagram/part/ModelingImportWizard.java > (original) > > +++ > commons/sandbox/gsoc/2010/scxml-eclipse/trunk/src/main/java/org.apache.commons.scxml.modeling.diagram/src/org/apache/commons/scxml/modeling/diagram/part/ModelingImportWizard.java > Fri Jul 16 03:02:10 2010 > > @@ -565,7 +565,7 @@ public class ModelingImportWizard extend > > public void widgetSelected(SelectionEvent > e) { > > FileDialog dialog = new > FileDialog(new Shell(), SWT.OPEN > > | > SWT.APPLICATION_MODAL); > > - dialog.setFilterExtensions(new > String[] { "*.xml" }); > > + dialog.setFilterExtensions(new > String[] { "*.xml","*.scxml" }); > > String path = dialog.open(); > > if (path != null) { > > filePath.setText(path); > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- Best Regards Gui Xun Long (桂训龙)
