DoubleMetaphone is not thread-safe - maxCodeLen field - but that could
be addressed later by adding a new ctor to set the field and make it
final.

The Manifest created by the Ant build file does not include the
compiler settings or OSGI headers.

default.properties uses junit 3.8.1 rather than 3.8.2

Otherwise looks OK

+1

On 24/07/2009, Niall Pemberton <niall.pember...@gmail.com> wrote:
> I have prepared a second release candidate for Codec 1.4 following the
>  feedback (thanks!) from the first.
>
>  [ ] +1 Yes go ahead an release based on RC2
>  [ ] -1 No, because...
>
>  The tag for RC2 is here:
>  http://svn.apache.org/viewvc/commons/proper/codec/tags/CODEC_1_4_RC2/
>
>  The release artefacts are here
>  http://people.apache.org/~niallp/codec-1.4-rc2/
>
>  Site is available here:
>  http://people.apache.org/~niallp/codec-1.4-rc2/site/
>  (note: some links are relative and will be broken until deployed to
>  proper codec home)
>
>  RAT Report:
>  http://people.apache.org/~niallp/codec-1.4-rc2/site/rat-report.html
>
>  CLIRR Report:
>  http://people.apache.org/~niallp/codec-1.4-rc2/site/clirr-report.html
>
>  Release Notes:
>  http://people.apache.org/~niallp/codec-1.4-rc2/site/changes-report.html
>  http://people.apache.org/~niallp/codec-1.4-rc2/RELEASE-NOTES.txt
>
>  Thanks
>
>  Niall
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>  For additional commands, e-mail: dev-h...@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to