On 18/05/2009, Ceki Gulcu <c...@qos.ch> wrote:
>
>
> sebb wrote:
>
> > On 18/05/2009, Ceki Gulcu <c...@qos.ch> wrote:
> >
> > >
> > > sebb wrote:
> > >
> > >
> > > > It would be useful if the Manifest included the following details:
> > > >
> > > > Implementation-Title: commons-logging
> > > > Implementation-Vendor: The Apache Software Foundation
> > > > Implementation-Vendor-Id: org.apache
> > > > Implementation-Version: 0.0.0-EMPTY
> > > > Specification-Title: commons-logging
> > > > Specification-Vendor: The Apache Software Foundation
> > > > Specification-Version: 0.0.0-EMPTY
> > > >
> > > >
> > > These details provide information to the user who decides to open the
> > > manifest file but other than that, since the jar file comes with no
> > > classes, the information cannot be accessed at runtime, e.g. by the
> > > Package class. Can you think of any additional reasons to include the
> > > above details in the manifest file?
> > >
> >
> > To document the jar.
> > It's easy enough to add, and does no harm.
> >
>
> Done.
Thanks, although IMO it would have been better to use
<manifest>
<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
<addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
</manifest>
rather than hard-coding the values.
Also, the pom <name> is wrong, it should be
<name>Commons Logging</name>
as per the existing pom.xml in logging/trunk.
The pom.xml for empty_logging should also have as parent either the
commons parent, or at least the apache parent.
That would allow the use of the default manifest entries as above.
>
> > AIUI there needs to be a NOTICE file in every distribution and release.
> >
>
> Done.
>
>
> > Also the N&L files need to be added to the jar.
> >
>
> Done.
>
> --
> Ceki Gülcü
> Logback: The reliable, generic, fast and flexible logging framework for
> Java.
> http://logback.qos.ch
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
