On Mon, May 11, 2009 at 1:45 PM, sebb <seb...@gmail.com> wrote: > On 11/05/2009, Christian Grobmeier <grobme...@gmail.com> wrote: >> Hi all, >> >> as already discussed, I just created a RC1 for the first [compress] release >> :-) >> Let me know if you can find any problems. >> >> Cheers, >> Christian >> >> >> Tag: >> >> https://svn.apache.org/repos/asf/commons/proper/compress/tags/commons-compress-1.0/ > > I don't like the use of final tag names for release candidates; tags > should be immutable, so how can one generate another release candidate > if this one fails? > > I'm not sure what the solution to this is as I don't know enough Maven. > > For the record, I have done the testing against "last changed revision: > 773463" > >> >> Site: >> http://people.apache.org/builds/commons/compress/1.0/RC1/site/index.html > > Could not find any reference to the required JVM version. > > Also the front page still refers partly to sandbox status: > > # The code is unreleased > # Methods and classes can and will appear and disappear without warning > # If you like the code and want to push it towards a release, join the > mailing list! > > Those both need to be fixed before live deployment of the site, but > are not release blockers. > >> Binaries: >> >> http://people.apache.org/builds/commons/compress/1.0/RC1/staged/org/apache/commons/commons-compress/1.0/ > > Hashes of sigs (.asc.md5 and .asc.sha1) are created by Maven, but > should be deleted as they serve no purpose. > > Hashes and sigs are OK. > > NOTICE file mentions products that came via the Ant project. I'm not > sure that's necessary, as Ant is an ASF project, but it probably does > no harm. > > jRPM appears to use AL 1.1 rather than AL 2.0, so the license text > from the jrpm project should be added to LICENSE file. > > The OSGI information in commons-compress-1.0.jar looks wrong - surely > the compress packages should only be listed in the Export section, and > not the Import section as well?
We relied on help from the experts from the felix project and use their tool to create the OSGi meta-data. If you think their tool is incorrect or want to find out how it works or why it does something then its better to ask these kind of questions on their user list: http://felix.apache.org/site/mailinglists.html This particular question though has already been answered on this mailing list when they were helping us with getting OSGi enabled: http://commons.markmail.org/message/lgmj7srrxhld42tp Niall > Presumably this is a pom.xml config error rather than a plugin error, > but I have no idea how to fix it. > > I think the Import section should be empty, as compress has no > dependencies (apart from junit for testing). I don't know if that > means it should be omitted, or just left empty. > > It would be nice if the source and javadoc manifest files contained > the Implementation and Specification details as provided in the binary > jar, but that is not essential. I'll see if I can find out how to add > this. > > CpioArchiveInputStreamTest.java does not have an AL header. > > Some of the test files don't have AL headers either, but that's probably OK. > > One test failure: > > testCpioUnarchive(org.apache.commons.compress.archivers.CpioTestCase) > junit.framework.AssertionFailedError: length of > C:\DOCUME~1\User\LOCALS~1\Temp\dir20685\test1.xml expected:<80> but > was:<76> > > Perhaps this is an EOL issue? > > Not a blocker. > >> [ ] +1 release it >> [ ] +0 go ahead I don't care >> [X] -1 no, do not release it because > > I think there's no point releasing with the OSGI error. > Also the jRPM LICENSE needs to be added, and the missing AL header. > > Hopefully also fix the source and javadoc manifests as well as the test > failure. > >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
