--- Jörg Schaible <[EMAIL PROTECTED]> wrote: > Forgot to add the path for the POM, just in case you > will do another RC. >
So... can you explain again what is the effect of moving [logging] to the separate dependencyManagement section of the POM? Thanks, Matt > Jörg Schaible wrote: > > > Hi Matt, > > > > Builds from source and works fine on my compiler > zoo except for all > > IBM-JDKs, but that's a different story > > (http://jira.codehaus.org/browse/MNG-3580). > > > > Some minor issues though in the docs: > > > > - download page goes nowhere, I suspect this is > caused by the current > > location and automatically fixed for the release > > - the links to the older APIs does not work, again > I suspect this is fixed > > for the release > > - the user's guide contains a table of content at > its top. However, quite > > all of the link anchors do not work > > > > Issue in the POM: > > > > - it defines a property "commons.release.version" > with value 1.2. This is > > used by the download-page-template.xml to generate > the download page in > > xdocs. Therefore currently all liks are generated > for JXPath 1.2. Maybe > > the property's value in the POM should be defined > as ${project.version} in > > general and its definition can move up to the > parent-pom. > > - it declares an optional provided dep to > commons-logging, which is simply > > not true, since jxpath does not make usage of > commons-logging. However > > commons-beanutils has it as transitive dep in an > old version, therefore > > commons-logging should be declared in a > dependencyManagement with version > > 1.1.1 to overwrite the old transitive version > > - it declares an optional runtime dep to > commons-collection, but it is not > > used by any other dependency and can therefore > removed completely (all > > tests run fine without it) > > - I don't under stand why deps are declared with > scope provided *and* > > optional. IMHO provided is enough, but it may have > also effect on the > > generated dependencies page > > > > Wiki: > > > > - talks about release plan for 1.2 ;-) > > > > > > Summary: > > -1, simply because of the wrong download links, > anything else is not > > critical > > > > - Jörg > > > Index: pom.xml > =================================================================== > --- pom.xml (Revision 674189) > +++ pom.xml (Arbeitskopie) > @@ -62,7 +62,7 @@ > > <properties> > > <commons.componentid>jxpath</commons.componentid> > - > <commons.release.version>1.2</commons.release.version> > + > <commons.release.version>{project.version}</commons.release.version> > <commons.binary.suffix /> > <commons.jira.id>JXPATH</commons.jira.id> > <commons.jira.pid>12310480</commons.jira.pid> > @@ -100,18 +100,21 @@ > </plugin> > </plugins> > </build> > + <dependencyManagement> > + <dependencies> > + <dependency> > + <groupId>commons-logging</groupId> > + <artifactId>commons-logging</artifactId> > + <version>1.1.1</version> > + </dependency> > + </dependencies> > + </dependencyManagement> > <dependencies> > <dependency> > - <groupId>commons-logging</groupId> > - <artifactId>commons-logging</artifactId> > - <version>1.1.1</version> > - <optional>true</optional> > - <scope>runtime</scope> > - </dependency> > - <dependency> > <groupId>xerces</groupId> > <artifactId>xercesImpl</artifactId> > <version>2.4.0</version> > + <scope>provided</scope> > <optional>true</optional> > </dependency> > <dependency> > @@ -154,13 +157,6 @@ > <optional>true</optional> > </dependency> > <dependency> > - <groupId>commons-collections</groupId> > - <artifactId>commons-collections</artifactId> > - <version>3.2</version> > - <optional>true</optional> > - <scope>runtime</scope> > - </dependency> > - <dependency> > <groupId>com.mockrunner</groupId> > > <artifactId>mockrunner-jdk1.3-j2ee1.3</artifactId> > <version>0.4</version> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: > [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
