Thanks for taking a look, Seb. --- sebb <[EMAIL PROTECTED]> wrote:
> 2008/5/1 Matt Benson <[EMAIL PROTECTED]>: > > First, thanks to all those who checked and found > > issues with RC1! > > > > The artifacts are here: > > http://people.apache.org/~mbenson/jxpath-1.3-rc2/ > > > > It would be nice if the Javadoc and Source MANIFEST > files contained a > bit more detail. > e.g. Implementation Version, Vendor etc. parent? > > The binary manifest says that the code is designed > for Java 1.3, yet > it was built and tested in Java 1.5. > > M2 requires only Java 1.4, so unless there is any > reason why that > cannot be used, at least it would be closer to the > target version. > This would at least catch any accidental usage of > Java 1.5+ methods. My primary dev environment is OSX... I guess I could boot to (blecch) Windows in the future... > > Ant build fails with Java 1.3.1: > > [junit] Testsuite: > org.apache.commons.jxpath.ri.StressTest > [junit] Tests run: 1, Failures: 0, Errors: 1, > Time elapsed: 1.078 sec > [junit] Tests run: 1, Failures: 0, Errors: 1, > Time elapsed: 1.078 sec > [junit] > [junit] Testcase: testThreads took 0.688 sec > [junit] Caused an ERROR > [junit] null > [junit] java.lang.NoSuchMethodError > [junit] at > org.apache.commons.jxpath.ri.StressTest$StressRunnable.run(StressTest.java:81) > [junit] at > java.lang.Thread.run(Thread.java:479) > [junit] > > Also, the Ant build refers to junit-3.8.2 - this is > not guaranteed to > work with Java 1.3 as there's a assert method that > requires Java 1.4 > in it. > This will cause a test failure - if it is used. > [There's a posting > about this in the archives earlier this year.] > I don't think this is the cause of the above error. > I'll look into these in the future, then. > > The tag is here: > > > http://svn.apache.org/viewvc/commons/proper/jxpath/tags/JXPATH_1_3_RC2/ > > > > The rat.xml file is set up to only check Java files. > It should really check all the files apart from > specific exceptions - > e.g. the JavaCC-generated files. > However, there don't appear to be any problems. Yep, see https://issues.apache.org/jira/browse/RAT-8 , which I see has been applied and resolved w/o sending me a notification, hmm. I'm not aware of what RAT version mvn is pulling, but I can go ahead and mod this in trunk now that they've applied my patch. > > A few SVN property problems: > > svn pd svn:executable > src/java/org/apache/commons/jxpath/util/JXPath11CompatibleTypeConverter.java > svn pd svn:executable > src/java/org/apache/commons/jxpath/util/ReverseComparator.java > svn pd svn:executable > src/test/org/apache/commons/jxpath/ri/model/beans/BadlyImplementedFactoryTest.java > > svn ps svn:eol-style native > src/java/org/apache/commons/jxpath/JXPathAbstractFactoryException.java > svn ps svn:eol-style native > src/java/org/apache/commons/jxpath/JXPathFunctionNotFoundException.java > svn ps svn:eol-style native > src/java/org/apache/commons/jxpath/JXPathInvalidAccessException.java > svn ps svn:eol-style native > src/java/org/apache/commons/jxpath/JXPathInvalidSyntaxException.java > svn ps svn:eol-style native > src/java/org/apache/commons/jxpath/JXPathNotFoundException.java > svn ps svn:eol-style native > src/java/org/apache/commons/jxpath/JXPathTypeConversionException.java > > Not sure about this one; check what the other JSPs > have: > > svn ps svn:eol-style native > src/test-webapp/JXPathTest.jsp Noted. > > These are not blockers. Thanks; do I assume your final vote comes out to a +0, -0, or what? :) -Matt > > Site: > > > http://people.apache.org/~mbenson/jxpath-1.3-rc2/site > > > > Clirr Report (compared to 1.2; one-shot not > working w/ > > M2) > > > http://people.apache.org/~mbenson/jxpath-1.3-rc2/clirr-report.txt > > > > I'd be grateful if you can make time to check the > > artifacts and cast your vote, which will be open > at > > least until Friday, May 9. > > > > Thanks, > > Matt > > > > > > > > > ____________________________________________________________________________________ > > Be a better friend, newshound, and > > know-it-all with Yahoo! Mobile. Try it now. > http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: > [EMAIL PROTECTED] > > For additional commands, e-mail: > [EMAIL PROTECTED] > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: > [EMAIL PROTECTED] > For additional commands, e-mail: > [EMAIL PROTECTED] > > ____________________________________________________________________________________ Be a better friend, newshound, and know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
