mlsorensen commented on code in PR #42:
URL: https://github.com/apache/cloudstack-go/pull/42#discussion_r989227715
##########
generate/generate.go:
##########
@@ -1629,7 +1651,11 @@ func (s *service) generateNewAPICallFunc(a *API) {
pn(" time.Sleep(500 * time.Millisecond)")
pn(" }")
} else {
- pn(" resp, err := s.cs.newRequest(\"%s\", p.toURLValues())",
a.Name)
+ if a.Name == "deployVirtualMachine" || a.Name == "login" ||
a.Name == "updateVirtualMachine" {
Review Comment:
That's a good point. I'm hesitant to default async APIs to use POST just
yet, that might need more thorough testing. Definitely something that can be
refined though, rather than sticking to just these few named APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
