rohityadavcloud commented on code in PR #42:
URL: https://github.com/apache/cloudstack-go/pull/42#discussion_r988598277
##########
generate/generate.go:
##########
@@ -1629,7 +1651,11 @@ func (s *service) generateNewAPICallFunc(a *API) {
pn(" time.Sleep(500 * time.Millisecond)")
pn(" }")
} else {
- pn(" resp, err := s.cs.newRequest(\"%s\", p.toURLValues())",
a.Name)
+ if a.Name == "deployVirtualMachine" || a.Name == "login" ||
a.Name == "updateVirtualMachine" {
Review Comment:
Just one suggestion, a.Isasync can be used to determine if a Post request be
made as for most async APIs, POST can be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
