Pearl1594 commented on a change in pull request #6:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/6#discussion_r722896360
##########
File path: GNUmakefile
##########
@@ -29,10 +29,10 @@ fmt:
gofmt -w $(GOFMT_FILES)
fmtcheck:
- @sh -c "'$(CURDIR)/scripts/gofmtcheck.sh'"
+ @bash -c "'$(CURDIR)/scripts/gofmtcheck.sh'"
Review comment:
The respective scripts have been written assuming that bash is
available. Do you suggest that the scripts be modified to run with sh ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
