Pearl1594 opened a new pull request #6:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/6
The PR fixes issues running few make commands:
#### Prior Fix:
```
$ make fmtcheck
==> Checking that code complies with gofmt requirements...
/home/pearl/go/src/github.com/apache/cloudstack-terraform-provider/scripts/gofmtcheck.sh:
25: [[: not found
$ make errcheck
==> Checking for unchecked errors...
/home/pearl/go/src/github.com/apache/cloudstack-terraform-provider/scripts/errcheck.sh:
36: [[: not found
```
#### Post Fix:
```
$ make fmtcheck
==> Checking that code complies with gofmt requirements...
$ make errcheck
==> Checking for unchecked errors...
==> Installing errcheck...
go get: installing executables with 'go get' in module mode is deprecated.
To adjust and download dependencies of the current module, use 'go
get -d'.
To install using requirements of the current module, use 'go
install'.
To install ignoring the current module, use 'go install' with a
version,
like 'go install example.com/cmd@latest'.
For more information, see
https://golang.org/doc/go-get-install-deprecation
or run 'go help get' or 'go help install'.
Unchecked errors found in the following places:
cloudstack/data_source_cloudstack_template.go:171:16: json.Unmarshal(t,
&templateJSON)
Please handle returned errors. You can check directly with `make errcheck`
make: *** [GNUmakefile:35: errcheck] Error 1
```
Successful run of `make errcheck` - identified unhandled errors - as seen
above
On fixing the missed error handling and changing `go get -u` to `go install`
for handling the deprecation warning
```
$ make errcheck
==> Checking for unchecked errors...
[13:38:08]
pearl@pearl-XPS-15-7590:~/go/src/github.com/apache/cloudstack-terraform-provider$
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
