onitake commented on a change in pull request #29:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/29#discussion_r635278142
##########
File path: Makefile
##########
@@ -21,7 +21,7 @@ GIT_COMMIT_SHORT=$(shell git rev-parse --short HEAD)
GIT_TAG=$(shell git describe --abbrev=0 --tags 2>/dev/null || echo v0.0.0)
GIT_IS_TAG=$(shell git describe --exact-match --abbrev=0 --tags 2>/dev/null ||
echo NOT_A_TAG)
ifeq (${GIT_IS_TAG},NOT_A_TAG)
-GIT_VERSION?=$(patsubst v%,%,${GIT_TAG})-master+${GIT_COMMIT}
+GIT_VERSION?=$(patsubst v%,%,${GIT_TAG})-main+${GIT_COMMIT}
Review comment:
k8s.io/kubernetes/pkg/version.gitVersion is an internal variable in the
k8s framework that will be used to print the product version, if you use the
option parsing functionality in the framework. Since our product is
cloudstack-kubernetes-provider and not Kubernetes, we can put whatever we want
in there. Approval from my side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
