onitake commented on a change in pull request #29:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/29#discussion_r635275404



##########
File path: cloudstack_loadbalancer.go
##########
@@ -121,8 +121,8 @@ func (cs *CSCloud) EnsureLoadBalancer(ctx context.Context, 
clusterName string, s
 
        klog.V(4).Infof("Load balancer %v is associated with IP %v", lb.name, 
lb.ipAddr)
 
-       // Fetch the IP whitelist from the spec if any
-       //whitelist = service.Spec.LoadBalancerSourceRanges
+       // Fetch the IP allowlist from the spec if any
+       //allowlist = service.Spec.LoadBalancerSourceRanges

Review comment:
       Hmmm I don't remember what this was for...
   Is it relevant for the needed 1.20 compatibility changes? If no, let's drop 
it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to