[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #657: vm wizard: add MAC Address validator

[GitBox]

utchoang commented on a change in pull request #657:
URL: https://github.com/apache/cloudstack-primate/pull/657#discussion_r484670978



##########
File path: src/views/compute/wizard/NetworkConfiguration.vue
##########
@@ -26,16 +26,40 @@
     :scroll="{ y: 225 }"
   >
     <template slot="ipAddress" slot-scope="text, record">
-      <a-input
-        style="width: 150px;"
-        :placeholder="$t('label.ipaddress')"
-        @change="($event) => updateNetworkData('ipAddress', record.id, 
$event.target.value)" />
+      <a-form-item>
+        <a-input
+          style="width: 150px;"
+          v-decorator="['ipAddress' + record.id, {
+            rules: [{
+              validator: validatorIpAddress,
+              cidr: record.cidr,
+              networkType: record.type
+            }]
+          }]"

Review comment:
       @davidjumani `Could you add a placeholder in the ipaddress input with 
the cidr ?`
   Do you mean like that?
   
![image](https://user-images.githubusercontent.com/13766648/92439064-4dde5a80-f1d4-11ea-8dfc-fcdf1f7a8e79.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org