davidjumani commented on a change in pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#discussion_r439469614
##########
File path: src/views/network/CreateSharedNetworkForm.vue
##########
@@ -589,11 +589,11 @@ export default {
if (this.isValidValueForKey(values, 'bypassvlanoverlapcheck')) {
params.bypassvlanoverlapcheck = values.bypassvlanoverlapcheck
}
- if (this.isValidValueForKey(values, 'isolatedpvlantype')) {
+ if (this.isValidValueForKey(values, 'isolatedpvlantype') &&
values.isolatedpvlantype !== 'none') {
params.isolatedpvlantype = values.isolatedpvlantype
- }
- if (this.isValidValueForKey(values, 'isolatedpvlan')) {
- params.isolatedpvlan = values.isolatedpvlan
+ if (this.isValidValueForKey(values, 'isolatedpvlan')) {
+ params.isolatedpvlan = values.isolatedpvlan
+ }
Review comment:
so we're verifying it only if the pvlan type is not none
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
