[GitHub] [cloudstack-primate] shwstppr commented on a change in pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type

[GitBox]

shwstppr commented on a change in pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#discussion_r439348341



##########
File path: src/views/network/CreateL2NetworkForm.vue
##########
@@ -109,6 +109,32 @@
           <a-form-item :label="$t('label.bypassvlanoverlapcheck')" 
v-if="!this.isObjectEmpty(this.selectedNetworkOffering) && 
this.selectedNetworkOffering.specifyvlan">
             <a-switch v-decorator="['bypassvlanoverlapcheck']" />
           </a-form-item>
+          <a-form-item :label="$t('label.isolatedpvlantype')" 
v-if="!this.isObjectEmpty(this.selectedNetworkOffering) && 
this.selectedNetworkOffering.specifyvlan">
+            <a-radio-group
+              v-decorator="['isolatedpvlantype', {
+                initialValue: this.isolatePvlanType
+              }]"
+              buttonStyle="solid"
+              @change="selected => { 
this.handleIsolatedPvlanTypeChange(selected.target.value) }">

Review comment:
       minor: can be simplified
   ```suggestion
                 @change="selected => { this.isolatePvlanType = 
selected.target.value }">
   ```

##########
File path: src/views/network/CreateL2NetworkForm.vue
##########
@@ -228,6 +255,9 @@ export default {
       this.selectedZone = zone
       this.updateVPCCheckAndFetchNetworkOfferingData()
     },
+    handleIsolatedPvlanTypeChange (pvlan) {
+      this.isolatePvlanType = pvlan
+    },

Review comment:
       ```suggestion
   ```

##########
File path: src/views/network/CreateSharedNetworkForm.vue
##########
@@ -589,11 +589,11 @@ export default {
         if (this.isValidValueForKey(values, 'bypassvlanoverlapcheck')) {
           params.bypassvlanoverlapcheck = values.bypassvlanoverlapcheck
         }
-        if (this.isValidValueForKey(values, 'isolatedpvlantype')) {
+        if (this.isValidValueForKey(values, 'isolatedpvlantype') && 
values.isolatedpvlantype !== 'none') {
           params.isolatedpvlantype = values.isolatedpvlantype
-        }
-        if (this.isValidValueForKey(values, 'isolatedpvlan')) {
-          params.isolatedpvlan = values.isolatedpvlan
+          if (this.isValidValueForKey(values, 'isolatedpvlan')) {
+            params.isolatedpvlan = values.isolatedpvlan
+          }

Review comment:
       Not sure if this really needs to go inside `isolatedpvlantype` if block. 
Anyway we are not showing `isolatedpvlan` field for `none` type




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org