koushik-das commented on a change in pull request #2072: WIP: CLOUDSTACK-9895 :
Added support for parallel volume(s) creation from a volume snapshot
URL: https://github.com/apache/cloudstack/pull/2072#discussion_r113936474
##########
File path:
framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java
##########
@@ -1012,6 +1018,22 @@ public void
doInTransactionWithoutResult(TransactionStatus status) {
s_logger.debug("Purge queue item for cancelled
job-" + job.getId());
}
_queueMgr.purgeAsyncJobQueueItemId(job.getId());
+
+ if(job.getInstanceType().equals("Volume")) {
+ // todo perform decrement opreation on the ref
count based on the volume and snapshot
+
+ try {
+
+ VolumeDetailVO volumeDetailVO =
_volumeDetailsDao.findDetail(job.getInstanceId(), "SNAPSHOT_ID");
Review comment:
Again this find and delete can be replaced with removeDetail()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
