koushik-das commented on a change in pull request #2072: WIP: CLOUDSTACK-9895 :
Added support for parallel volume(s) creation from a volume snapshot
URL: https://github.com/apache/cloudstack/pull/2072#discussion_r113931425
##########
File path:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
##########
@@ -2025,4 +2037,27 @@ public VolumeInfo
updateHypervisorSnapshotReserveForVolume(DiskOffering diskOffe
return volFactory.getVolume(volumeId);
}
+
+ /**
+ * inserts volume,snapshot details
+ * @param volumeId
+ * @param snapsShotid
+ */
+ public void insertVolumeDetailsVO(Long volumeId,Long snapsShotid)
Review comment:
What is the need for this method? There is already a method addDetail() in
VolumeDetailsDaoImpl.java. I would suggest checking the existing code to see
what all are already available before implementing something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
