Github user anshul1886 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1867#discussion_r106387348
  
    --- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java
 ---
    @@ -191,7 +191,8 @@ public void 
processEvent(ObjectInDataStoreStateMachine.Event event) {
                 s_logger.debug("Failed to update state:" + e.toString());
                 throw new CloudRuntimeException("Failed to update state: " + 
e.toString());
             } finally {
    -            if (event == 
ObjectInDataStoreStateMachine.Event.OperationFailed) {
    +            DataObjectInStore obj = objectInStoreMgr.findObject(this, 
this.getDataStore());
    +            if (event == 
ObjectInDataStoreStateMachine.Event.OperationFailed && 
!obj.getState().equals(ObjectInDataStoreStateMachine.State.Destroying)) {
    --- End diff --
    
    @koushik-das obj cannot be null as that method is kind of called on that 
object itself. That method is fetching it from DB for some more details. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to