Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1867#discussion_r106385035
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java
---
@@ -191,7 +191,8 @@ public void
processEvent(ObjectInDataStoreStateMachine.Event event) {
s_logger.debug("Failed to update state:" + e.toString());
throw new CloudRuntimeException("Failed to update state: " +
e.toString());
} finally {
- if (event ==
ObjectInDataStoreStateMachine.Event.OperationFailed) {
+ DataObjectInStore obj = objectInStoreMgr.findObject(this,
this.getDataStore());
+ if (event ==
ObjectInDataStoreStateMachine.Event.OperationFailed &&
!obj.getState().equals(ObjectInDataStoreStateMachine.State.Destroying)) {
--- End diff --
@koushik-das If there is failure in destroying snapshot then we should not
delete db entry so that it can be used to detect which snapshots failed to
delete successfully.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
