Github user karuturi commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/695#discussion_r37157665
  
    --- Diff: 
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java ---
    @@ -375,6 +377,18 @@ public void uploadFile(String urlString, File 
localFile) throws Exception {
             }
         }
     
    +    private Charset getCharSetFromConnection(HttpURLConnection conn) {
    --- End diff --
    
    Hi Daan, I didnt see any usages for it except for VmwareContext. May be 
utility method to get character encoding from a URL would be useful than a 
connection. Can I take this up later?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to