Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/695#discussion_r37133264
--- Diff: utils/src/com/cloud/utils/StringUtils.java ---
@@ -52,7 +52,7 @@ public static boolean isUtf8Supported() {
return Charset.isSupported(UTF8);
}
- public static Charset getDefaultCharset() {
+ protected static Charset getDefaultCharset() {
--- End diff --
looking at the history of it, i thought it was introduced only to help in
testing. Also, i didnt see any reason why we should use defaultCharset(which
anway is easy to get). We should be using preferred charset everywhere. I would
say, lets make it public when we see a need.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
