Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36514806
--- Diff: ui/scripts/vpc.js ---
@@ -155,41 +155,41 @@
};
*/
//virtualmachineids parameter has been replaced with
vmidipmap parameter, so comment out the lines above.
-
-
+
+
var inputData = {
id: args.context.internalLoadBalancers[0].id
- };
- /*
+ };
+ /*
* e.g. first VM(xxx) has two IPs(10.1.1.~), second
VM(yyy) has three IPs(10.2.2.~):
- * vmidipmap[0].vmid=xxx vmidipmap[0].vmip=10.1.1.11
- * vmidipmap[1].vmid=xxx vmidipmap[1].vmip=10.1.1.12
- * vmidipmap[2].vmid=yyy vmidipmap[2].vmip=10.2.2.77
- * vmidipmap[3].vmid=yyy vmidipmap[3].vmip=10.2.2.78
- * vmidipmap[4].vmid=yyy vmidipmap[4].vmip=10.2.2.79
+ * vmidipmap[0].vmid=xxx vmidipmap[0].vmip=10.1.1.11
+ * vmidipmap[1].vmid=xxx vmidipmap[1].vmip=10.1.1.12
+ * vmidipmap[2].vmid=yyy vmidipmap[2].vmip=10.2.2.77
+ * vmidipmap[3].vmid=yyy vmidipmap[3].vmip=10.2.2.78
+ * vmidipmap[4].vmid=yyy vmidipmap[4].vmip=10.2.2.79
*/
var selectedVMs = vms;
if (selectedVMs != null) {
var vmidipmapIndex = 0;
- for (var vmIndex = 0; vmIndex < selectedVMs.length;
vmIndex++) {
+ for (var vmIndex = 0; vmIndex < selectedVMs.length;
vmIndex++) {
var selectedIPs = selectedVMs[vmIndex]._subselect;
for (var ipIndex = 0; ipIndex <
selectedIPs.length; ipIndex++) {
inputData['vmidipmap[' + vmidipmapIndex +
'].vmid'] = selectedVMs[vmIndex].id;
-
- //"ipAddresses" is not in args.context since
this LB rule is under a VPC, not an address.
+
+ //"ipAddresses" is not in args.context since
this LB rule is under a VPC, not an address.
/*
--- End diff --
yet another useless bit reformatted
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
