----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23735/#review79037 -----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board. We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted). Please consider submitting a pull request. Great instructions are available at: https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more. - Sebastien Goasguen On July 22, 2014, 7:24 a.m., Miguel Ferreira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23735/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 7:24 a.m.) > > > Review request for cloudstack, daan Hoogland, John Dilley, Santhosh Edukulla, > and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > The DevCloud wiki page [1] instructs developers to deploy a DC with basic > networking with the following command: > $ python tools/marvin/marvin/deployDataCenter.py -i > tools/devcloud/devcloud-advanced.cfg > > > However, that produces the error message bellow: > > Exception Occurred Under createLogs :['Traceback (most recent call > last):\n', ' File > "/Users/mferreira/development/git/cloudstack-sbp/tools/marvin/marvin/marvinLog.py", > line 157, in createLogs\n (\'LogFolderPath\' in log_cfg.__dict__.keys()) > and\n', "AttributeError: 'list' object has no attribute '__dict__'\n"] > > ===Log Creation Failed. Please Check=== > > > The cause of the error is the unexpected format of the logger element in > tools/devcloud/devcloud-advanced.cfg > The patch I'm submitting add support for lists in the logger element of the > configuration. > > [1] - https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud > > > Diffs > ----- > > tools/marvin/marvin/deployDataCenter.py ae48839 > tools/marvin/marvin/marvinLog.py ea8eaee > > Diff: https://reviews.apache.org/r/23735/diff/ > > > Testing > ------- > > With the patch I was able to deploy a zone in cloudstack. > > > Thanks, > > Miguel Ferreira > >
