Thanks Rajani, I relied on the annotations in eclipse. Looking at the git blame output I see that the line was a fix indeed after the branching and cherry-picked it.
lesson learned: annotations in eclipse are fine if right but confusing when faulty. apologies, On Fri, Feb 27, 2015 at 8:18 AM, Rajani Karuturi <raj...@apache.org> wrote: > I think the fix in master is right. The cherry-pick you did on 4.4 should > fix it for 4.4 as well. > > following the git [history, blame] this is what i think happened > > CLOUDSTACK-1966 initial fix (fix is on 4.3, 4.4, 4.5 and master ) > 8 months later, another defect in the same area for custom disk offering > CLOUDSTACK-5554 (fix is on 4.3, 4.4, 4.5, master ) > which introduced another defect CLOUDSTACK-7760 which was identified after > 10 months ( fix is on 4.5 and master) > > > > ~Rajani > > On Thu, Feb 26, 2015 at 8:25 PM, Daan Hoogland <daan.hoogl...@gmail.com> > wrote: > >> Fellow debs, >> >> Sonali reported a bug on users@ and I checked the code as checked in >> for CLOUDSTACK-1966. It is not applicable anymore. I think this peace >> of code has be fixed on several release branches by different people. >> The code in master contains a line from 2010 that is not in 4.4. >> Anyone has an expert opinion on how this accounting issue should be >> implemented? >> >> thanks, >> >> On Thu, Feb 26, 2015 at 3:02 PM, Sonali Jadhav >> <son...@servercentralen.se> wrote: >> > Hi Prashant, >> > >> > I have reported both bugs >> > >> > https://issues.apache.org/jira/browse/CLOUDSTACK-8283 >> > >> > https://issues.apache.org/jira/browse/CLOUDSTACK-8284 >> > >> > But I observed that my bug id 8283, has already been reported in >> april-2013 for 4.2.0 >> https://issues.apache.org/jira/browse/CLOUDSTACK-1966 ,and issue is >> closed. >> > >> > And I am running 4.4.2, but I am still getting same issue. >> > >> > /Sonali >> > >> > -----Original Message----- >> > From: Prashant Kumar Mishra [mailto:prashantkumar.mis...@citrix.com] >> > Sent: Friday, February 20, 2015 4:21 PM >> > To: us...@cloudstack.apache.org >> > Subject: Re: Primary storage limit issue >> > >> > >> > >> > On 2/20/15, 10:46 AM, "Sonali Jadhav" <son...@servercentralen.se> wrote: >> > >> >>Anyone help? >> >> >> >>/Sonali >> >> >> >>-----Original Message----- >> >>From: Sonali Jadhav [mailto:son...@servercentralen.se] >> >>Sent: Thursday, February 19, 2015 10:34 AM >> >>To: us...@cloudstack.apache.org >> >>Subject: RE: Primary storage limit issue >> >> >> >>Hi, >> >> >> >>Yes, in resource_count table, I found this , >> >> >> >>mysql> select * from resource_count where domain_id=3; >> >>+-----+------------+-----------+-------------------+-------------+ >> >>| id | account_id | domain_id | type | count | >> >>+-----+------------+-----------+-------------------+-------------+ >> >>| 113 | NULL | 3 | user_vm | 0 | >> >>| 114 | NULL | 3 | public_ip | 0 | >> >>| 115 | NULL | 3 | volume | 0 | >> >>| 116 | NULL | 3 | snapshot | 0 | >> >>| 117 | NULL | 3 | template | 0 | >> >>| 118 | NULL | 3 | project | 0 | >> >>| 119 | NULL | 3 | network | 0 | >> >>| 120 | NULL | 3 | vpc | 0 | >> >>| 121 | NULL | 3 | cpu | 0 | >> >>| 122 | NULL | 3 | memory | 0 | >> >>| 123 | NULL | 3 | primary_storage | 65498251264 | >> >>| 124 | NULL | 3 | secondary_storage | 0 | >> >>+-----+------------+-----------+-------------------+-------------+ >> >> >> >>So then I logged into same domain from UI, and in "Domains" section >> >>clicked on "update resource count". After which in resource_count table >> >>"primary_storage" table value went back to zero. Is this a bug ? >> >>Because such way every time domain admin has to update resource count >> >>to do actual reset. >> > >> >>>There should be a bug on this (check jira):After release of resource >> >>>resource_count table should be updated accordingly >> >> >> >>2nd Bug, I have observed, I had set primary storage limit on domain to >> >>40GB, On account there is no limit defined. From domain admin login >> >>when I try to create first instance, I can add disk of any size, e.g. I >> >>gave 200GB disk and it created instance without any error. But when I >> >>try to add more disk or new instance with nay disk size it gives error, >> >>that resource limit is exceeded. >> >> >> >>So how come domain admin can create 200GB primary storage instance when >> >>limit is set to 40GB ? >> > >> >>>>Again it is an issue please open a ticket. >> >>In what priorities resource count limits are considered by cloudstack ? >> >>I thought it was 1. global settings, 2. Domain, 3. Account, 4. >> >>Project >> >> >> >> >> >>/Sonali >> >> >> >>-----Original Message----- >> >>From: Prashant Kumar Mishra [mailto:prashantkumar.mis...@citrix.com] >> >>Sent: Thursday, February 19, 2015 10:15 AM >> >>To: us...@cloudstack.apache.org >> >>Subject: Re: Primary storage limit issue >> >> >> >>Since volumes are expunged , Only possibility is resource_count table >> >>, please update the primary storage count to zero (seems a bug to me). >> >> >> >>On 2/18/15, 8:08 PM, "Somesh Naidu" <somesh.na...@citrix.com> wrote: >> >> >> >>>Have you looked at the resource_count table? >> >>> >> >>>Can you try updating resource count (UI/API) to see if that fixes the >> >>>issue. >> >>> >> >>>Regards, >> >>>Somesh >> >>> >> >>>-----Original Message----- >> >>>From: Sonali Jadhav [mailto:son...@servercentralen.se] >> >>>Sent: Wednesday, February 18, 2015 8:05 AM >> >>>To: us...@cloudstack.apache.org >> >>>Subject: RE: Primary storage limit issue >> >>> >> >>>Hi, >> >>> >> >>>Yes capacity checker is running. >> >>> >> >>>mysql> select >> >>>domain_id,name,recreatable,created,attached,updated,removed,state from >> >>>volumes; >> >> >>>+-----------+-----------------------+-------------+---------------------+ >> >>>- >> >>>---------+---------------------+---------------------+----------+ >> >>>| domain_id | name | recreatable | created >> | >> >>>attached | updated | removed | state | Size | >> >> >>>+-----------+-----------------------+-------------+---------------------+ >> >>>- >> >>>---------+---------------------+---------------------+----------+ >> >>>| 3 | ROOT-16 | 0 | 2015-02-18 08:29:34 >> | >> >>>NULL | 2015-02-18 08:42:40 | 2015-02-18 08:42:40 | Expunged | >> >>>21474836480 | >> >>>| 3 | ROOT-17 | 1 | 2015-02-18 08:28:18 >> | >> >>>NULL | 2015-02-18 13:00:07 | 2015-02-18 13:00:07 | Expunged | >> >>>2621440000 | >> >>>| 3 | ROOT-18 | 0 | 2015-02-18 08:56:07 >> | >> >>>NULL | 2015-02-18 09:07:25 | 2015-02-18 09:07:25 | Expunged | >> >>>44023414784 | >> >>> >> >>> >> >>>Above are the only 3 values I could find in volumes tables for domain >> >>>id 3. >> >>>And still I am getting error that " Maximum number of resources of >> >>>type 'primary_storage' for domain id=3 has been exceeded" >> >>> >> >>> >> >>> >> >>>/Sonali >> >>> >> >>>-----Original Message----- >> >>>From: Prashant Kumar Mishra [mailto:prashantkumar.mis...@citrix.com] >> >>>Sent: Wednesday, February 18, 2015 5:43 PM >> >>>To: us...@cloudstack.apache.org >> >>>Subject: Re: Primary storage limit issue >> >>> >> >>>1-Capacity checkers is running ( can be found in global settings) ? >> >>> >> >>>2- Check volumes table if there are some volume in which are not >> >>>destroyed . >> >>> >> >>> >> >>>Thanks >> >>>prashant >> >>> >> >>>From: Sonali Jadhav >> >>><son...@servercentralen.se<mailto:son...@servercentralen.se>> >> >>>Reply-To: >> >>>"us...@cloudstack.apache.org<mailto:us...@cloudstack.apache.org>" >> >>><us...@cloudstack.apache.org<mailto:us...@cloudstack.apache.org>> >> >>>Date: Wednesday, February 18, 2015 at 3:17 PM >> >>>To: "us...@cloudstack.apache.org<mailto:us...@cloudstack.apache.org>" >> >>><us...@cloudstack.apache.org<mailto:us...@cloudstack.apache.org>> >> >>>Subject: Primary storage limit issue >> >>> >> >>>Forgot attachment, sending mail again. :) >> >>> >> >>>/Sonali >> >>> >> >>>From: Sonali Jadhav >> >>>Sent: Wednesday, February 18, 2015 3:15 PM >> >>>To: us...@cloudstack.apache.org<mailto:us...@cloudstack.apache.org> >> >>>Subject: Primary storage limit issue >> >>> >> >>>Hi, >> >>> >> >>>I have strange issue with resource limits set on sub-domain. >> >>>I was doing some tests for checking resource limitation behavior on >> >>>sub-domain, a/c and project. >> >>> >> >>>For account , I didn't set any limits. Instead I set limits on >> >>>sub-domain. But this specific Primary storage limit(40GB) acted weird. >> >>>At first in sub-domain, I created new instance (without project), and >> >>>assigned 41 GB, and it successfully created VM. Then I deleted that VM >> >>>with Expunge option enabled, and tried to create vm again with disk >> >>>size 42, which failed with error "Maximum number of resources of type >> >>>'primary_storage' for domain id=3 has been exceeded" >> >>>Then I gave disk size to 39GB, that also failed with same error. And >> >>>now if I create any disk size its failing. There are no instances or >> >>>volumes under that sub-domain. >> >>>What could be the problem ? >> >>> >> >>>Have a look at attached log file. >> >>> >> >>>Thanks, >> >>>/Sonali >> >>> >> >>> >> >>> >> >>> >> >> >> >> >> >> >> >> >> >> >> > >> > >> > >> >> >> >> -- >> Daan >> -- Daan
