Rohit, this was discussed on list. I intentionally branched in order not to have reverts for failed RCs in the release branch. I don't care either way but there was a trend to go this way (deleting branches of RCs that got voted out).
as said we can rename the branch now to GA-4.4.1 and delete any old RC-branch. I don't understand the part about debian branches you refer to. It seems like a packaging issue to me. Can you explain? On Mon, Oct 20, 2014 at 12:27 PM, Rohit Yadav <rohit.ya...@shapeblue.com> wrote: > Hi, > > There are multiple issues to report; > > - Both 4.4.0 and 4.4.1 tags are not on 4.4 branch, we can leave them as > you say the trend now is to not put tags on branch. I personally think it > would bug because I had always assumed the tag was in the release branch. > But then does that mean you want to keep the RC branch? > > - Both 4.4.0 and 4.4.1 tagged releases have -snapshot in debian/changelog > resulting in debian package names which should be 4.4.0 or 4.4.1 and not > 4.4.0-snapshot or 4.4.1-snapshot. This is not the case in case of > 4.3.1/4.3.0 and past releases. > > I would propose to remove -snapshots as it is not informative or useful; > just using the version name without -snapshot reduces divergence between > release/master branches and build related issues. > > > On 20-Oct-2014, at 1:18 pm, Daan Hoogland <daan.hoogl...@gmail.com> > wrote: > > > > take a look in build_asf.sh I changed it to not have to revert RCs in > case > > they didn't pass. Also if issues are only packaging we could stay on the > > branch. I saw this practice wasn't promoted to master and hence 4.5 but i > > think it should. Unless we go with your proposal of not snapshotting of > > course. > > > > On Mon, Oct 20, 2014 at 9:41 AM, Rohit Yadav <rohit.ya...@shapeblue.com> > > wrote: > > > >> Hi Daan, > >> > >>> On 20-Oct-2014, at 1:02 pm, Daan Hoogland <daan.hoogl...@gmail.com> > >> wrote: > >>> > >>> no, the release is on that branch not on the 4.4 branch. We could > rename > >>> the branch if needed. putting the tag on 4.4 would make it either a > >>> 4.4.1-SNAPSHOT or a 4.4.2-SNAPSHOT depending on where on the branch we > >> put > >>> the tag. > >> > >> If you look at other branches, 4.2, 4.3 etc all the tagged releases are > >> done on the branch; there is no separate release branch like in this > case > >> 4.4-RC20141014T2316. It’s just a matter of ease here, I can always git > >> fetch and checkout a tag, but historically we’ve put tags on the release > >> branch that we cut out. > >> > >> I also wanted to discuss why we add -SNAPSHOT at all, what’s the harm in > >> say keep the next version to 4.4.2 (if we have 4.4.2 in future)? This > >> diverges code (in git terms) a lot, why not just switch to the next > >> version? When building rpms or debs (in changelog), we can still add a > >> suffix but those changes would introduce minimal divergence. > >> > >> Regards, > >> Rohit Yadav > >> Software Architect, ShapeBlue > >> M. +91 88 262 30892 | rohit.ya...@shapeblue.com > >> Blog: bhaisaab.org | Twitter: @_bhaisaab > >> > >> Find out more about ShapeBlue and our range of CloudStack related > services > >> > >> IaaS Cloud Design & Build< > >> http://shapeblue.com/iaas-cloud-design-and-build//> > >> CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/ > > > >> CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/> > >> CloudStack Infrastructure Support< > >> http://shapeblue.com/cloudstack-infrastructure-support/> > >> CloudStack Bootcamp Training Courses< > >> http://shapeblue.com/cloudstack-training/> > >> > >> This email and any attachments to it may be confidential and are > intended > >> solely for the use of the individual to whom it is addressed. Any views > or > >> opinions expressed are solely those of the author and do not necessarily > >> represent those of Shape Blue Ltd or related companies. If you are not > the > >> intended recipient of this email, you must neither take any action based > >> upon its contents, nor copy or show it to anyone. Please contact the > sender > >> if you believe you have received this email in error. Shape Blue Ltd is > a > >> company incorporated in England & Wales. ShapeBlue Services India LLP > is a > >> company incorporated in India and is operated under license from Shape > Blue > >> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in > Brasil > >> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd > is > >> a company registered by The Republic of South Africa and is traded under > >> license from Shape Blue Ltd. ShapeBlue is a registered trademark. > >> > > > > > > > > -- > > Daan > > Regards, > Rohit Yadav > Software Architect, ShapeBlue > M. +91 88 262 30892 | rohit.ya...@shapeblue.com > Blog: bhaisaab.org | Twitter: @_bhaisaab > > > > Find out more about ShapeBlue and our range of CloudStack related services > > IaaS Cloud Design & Build< > http://shapeblue.com/iaas-cloud-design-and-build//> > CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/> > CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/> > CloudStack Infrastructure Support< > http://shapeblue.com/cloudstack-infrastructure-support/> > CloudStack Bootcamp Training Courses< > http://shapeblue.com/cloudstack-training/> > > This email and any attachments to it may be confidential and are intended > solely for the use of the individual to whom it is addressed. Any views or > opinions expressed are solely those of the author and do not necessarily > represent those of Shape Blue Ltd or related companies. If you are not the > intended recipient of this email, you must neither take any action based > upon its contents, nor copy or show it to anyone. Please contact the sender > if you believe you have received this email in error. Shape Blue Ltd is a > company incorporated in England & Wales. ShapeBlue Services India LLP is a > company incorporated in India and is operated under license from Shape Blue > Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil > and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is > a company registered by The Republic of South Africa and is traded under > license from Shape Blue Ltd. ShapeBlue is a registered trademark. > -- Daan
