Hi David, On 23-Sep-2014, at 11:50 pm, David Nalley <da...@gnsa.us> wrote: > Yes, GH PR is exactly like the Review Board emails in this particular > aspect. My question is why is this merged into master rather than a > feature branch, and why no [MERGE] email as per: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Branch+Merge+Expectations
Ah, my bad. I did not consider the process/syntax around it. There was some initial email on this but it did not start with a “[MERGE]” but started with “rfc:” for merging it on master: http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201407.mbox/%3C7A6CF878-7A28-4D4A-BCD2-0C264F8C90B7%40schubergphilis.com%3E I also forgot that this process should apply for merging changes from reviewboard and Github PR as well. That’s completely my fault to not enforce the branch merging process on this PR. The only thing I can offer now is to make sure that this work won’t break build or anything else on master/4.5.0 Regards, Rohit Yadav Software Architect, ShapeBlue M. +41 779015219 | rohit.ya...@shapeblue.com Blog: bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design & Build<http://shapeblue.com/iaas-cloud-design-and-build//> CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/> CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/> CloudStack Infrastructure Support<http://shapeblue.com/cloudstack-infrastructure-support/> CloudStack Bootcamp Training Courses<http://shapeblue.com/cloudstack-training/> This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
