Hi David, On 23-Sep-2014, at 8:31 pm, David Nalley <da...@gnsa.us> wrote: > Where was the merge request for this huge merge to master? (it was at > 50 commit emails, when it stopped sending, ) > We have passed feature freeze for 4.5.0, so I am confused as why this > was merged. Is there a reason not to revert all of this?
This was the request: https://github.com/apache/cloudstack/pull/16 And JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-7143 We all get emails from Github PR (just re-checked) so you may find them on the ML. I was reviewing this Github pull request which came in couple of weeks ago. This is well tested and successfully refactors the way we build systemvms. It was only merged when it passed build tests and painful manual QA (I did on KVM). Just want to mention that this is not my code or $dayjob work, I was just trying to help out the contribution from community member(s). Pardon my ignorance but I was not aware about our official status of master/4.5.0 that we’re already passed feature freeze. Can you confirm the official stand/status on master/4.5.0 and when do we plan to cut the release branch, and if we are changing anything with the way we do releases etc? I see a lot of changes that comes in every other day on master. The pattern I see is that developers check-in barely working feature and then find the excuse to check-in more patches/commits as bug fixes where they actually are trying to complete an incomplete feature. I think this is a chronic issue which should be checked and everyone should make an effort to work in their feature branch, work on their git-foo, rebase/fix-conflicts and send merge request or Github pull requests or request using reviewboard. I think this will allow all of us to participate in on-going efforts and would help improve its quality using QA and code reviewing. Regards, Rohit Yadav Software Architect, ShapeBlue M. +41 779015219 | rohit.ya...@shapeblue.com Blog: bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design & Build<http://shapeblue.com/iaas-cloud-design-and-build//> CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/> CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/> CloudStack Infrastructure Support<http://shapeblue.com/cloudstack-infrastructure-support/> CloudStack Bootcamp Training Courses<http://shapeblue.com/cloudstack-training/> This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
