----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25647/#review53489 -----------------------------------------------------------
server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/25647/#comment93133> yeah, as i observed a new rootdisksize variable has been indroduced in deployVM api for 4.4 onwards, which enables the user to give his own root disk size greater than the current template size. which in turn will override the template size by the given rootdisksize, hence our SAN volume will be created based on the inputted rootdisksize by the admin. no, the user must be having a prior knowledge of whether the templates is in S3/Swift or nfs, if the user is using the normal nfs store, he need not specify the size since the template is already contains the processed virtual size. yes, this is the challenge i'm facing right now, since user has no prior knowledge of the infrastructure nor that we are able to list the infrastructure in the user mode. hence i'm assuming that the admin will inform the user about this awareness and the sizes to be given for the corrensponding templates. - punith s On Sept. 15, 2014, 7:41 p.m., punith s wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25647/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2014, 7:41 p.m.) > > > Review request for cloudstack, amit kumar das and Mike Tutkowski. > > > Bugs: 7406 > https://issues.apache.org/jira/browse/7406 > > > Repository: cloudstack-git > > > Description > ------- > > since cloudstack is not able to process the S3 or Switf templates for its > virtual size(root disk size), admin is facing issues while creating a vm > using third party storage plugins like cloudbyte and solidfire etc. > this patch enables the resize of root disk, on passing a variable > ismanagedstorage = true in deployVmCmd as a detail. > hence template root disksize is overriden by the given rootdisk size by the > admin > > this patch also fixes the iops null issue. > > for more ref > https://issues.apache.org/jira/browse/CLOUDSTACK-7406 > > > Diffs > ----- > > > engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java > 2b49954 > server/src/com/cloud/vm/UserVmManagerImpl.java 0ea2a89 > > Diff: https://reviews.apache.org/r/25647/diff/ > > > Testing > ------- > > dry run only. > > > Thanks, > > punith s > >
