----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25647/#review53488 -----------------------------------------------------------
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java <https://reviews.apache.org/r/25647/#comment93132> yes mike, when you create a compute offering with a specified min and max iops on contrary to the custom iops, iops was setting null for the root disk, since a new rootdiskoffering object is being created, predefined iops were not being set. and yes, this issue is not related to this S3 bug, but i thought it to be a minor one, so i clubbed it with this review. - punith s On Sept. 15, 2014, 7:41 p.m., punith s wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25647/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2014, 7:41 p.m.) > > > Review request for cloudstack, amit kumar das and Mike Tutkowski. > > > Bugs: 7406 > https://issues.apache.org/jira/browse/7406 > > > Repository: cloudstack-git > > > Description > ------- > > since cloudstack is not able to process the S3 or Switf templates for its > virtual size(root disk size), admin is facing issues while creating a vm > using third party storage plugins like cloudbyte and solidfire etc. > this patch enables the resize of root disk, on passing a variable > ismanagedstorage = true in deployVmCmd as a detail. > hence template root disksize is overriden by the given rootdisk size by the > admin > > this patch also fixes the iops null issue. > > for more ref > https://issues.apache.org/jira/browse/CLOUDSTACK-7406 > > > Diffs > ----- > > > engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java > 2b49954 > server/src/com/cloud/vm/UserVmManagerImpl.java 0ea2a89 > > Diff: https://reviews.apache.org/r/25647/diff/ > > > Testing > ------- > > dry run only. > > > Thanks, > > punith s > >
