> On Sept. 10, 2014, 11:55 a.m., Rohit Yadav wrote:
> > ui/scripts/system.js, lines 16106-16107
> > <https://reviews.apache.org/r/25429/diff/1/?file=682469#file682469line16106>
> >
> >     This probably does not apply for ACS? Is this for CCP?
> >     
> >     Can you fix/test with ACS master?

Please see the updated diff. The new fields should only be visible if the host 
has these details.
Thanks.


- Mihaela


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25429/#review52850
-----------------------------------------------------------


On Sept. 10, 2014, 1:19 p.m., Mihaela Stoica wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25429/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2014, 1:19 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle and Jessica Wang.
> 
> 
> Bugs: CLOUDSTACK-7502
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7502
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> - Added Agent version and Qemu version fields to the Host detail page, with 
> the values from the host's details field
> - Only displayed for KVM hosts, as the details field is not defined for other 
> hypervisors
> 
> 
> Diffs
> -----
> 
>   client/WEB-INF/classes/resources/messages.properties 4655973 
>   ui/dictionary.jsp 0102144 
>   ui/scripts/system.js ed53fd2 
> 
> Diff: https://reviews.apache.org/r/25429/diff/
> 
> 
> Testing
> -------
> 
> Tested with a KVM host: the two fields are displayed.
> Tested with a XenServer host: fields not shown.
> 
> Screenshots attached to the ticket.
> 
> 
> Thanks,
> 
> Mihaela Stoica
> 
>

Reply via email to