> On Sept. 10, 2014, 11:32 a.m., Rohit Yadav wrote: > > Thanks for your contribution, can you share with us if this was tested and > > with UI contributions can we see a screenshot with/without KVM hosts.
Thank you for your comments. I've just updated the "testing" section. Also attached screenshots to the ticket CLOUDSTACK-7502. - Mihaela ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25429/#review52848 ----------------------------------------------------------- On Sept. 10, 2014, 11:50 a.m., Mihaela Stoica wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25429/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2014, 11:50 a.m.) > > > Review request for cloudstack, Brian Federle and Jessica Wang. > > > Repository: cloudstack-git > > > Description > ------- > > - Added Agent version and Qemu version fields to the Host detail page, with > the values from the host's details field > - Only displayed for KVM hosts, as the details field is not defined for other > hypervisors > > > Diffs > ----- > > client/WEB-INF/classes/resources/messages.properties 4655973 > ui/dictionary.jsp 0102144 > ui/scripts/system.js cf3b9dc > > Diff: https://reviews.apache.org/r/25429/diff/ > > > Testing > ------- > > Tested with a KVM host: the two fields are displayed. > Tested with a XenServer host: fields not shown. > > Screenshots attached to the ticket. > > > Thanks, > > Mihaela Stoica > >