> On Sept. 10, 2014, 10:29 a.m., Rohit Yadav wrote: > > Just want to check with other reviewers, if this contribution is good to > > merge on master? Bharat, if you may confirm that it is well tested on > > Xen/KVM?
The fix looks correct and it can be merged. The issue was that with custom offerings the profile wasn't getting initialized correctly and it lacked the cpu and memory details. This would cause a null pointer exception in the allocators. I can apply the patch if no one else is working on it. - Devdeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/#review52846 ----------------------------------------------------------- On Sept. 8, 2014, 1:55 p.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25430/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2014, 1:55 p.m.) > > > Review request for cloudstack, Alena Prokharchyk, Devdeep Singh, edison su, > Koushik Das, Mike Tutkowski, and Nitin Mehta. > > > Bugs: CLOUDSTACK-6099 > https://issues.apache.org/jira/browse/CLOUDSTACK-6099 > > > Repository: cloudstack-git > > > Description > ------- > > live migration is failing for vm deployed using dynaic compute offerings with > NPE > https://issues.apache.org/jira/browse/CLOUDSTACK-6099 > > > Diffs > ----- > > engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java > 8edef77 > > Diff: https://reviews.apache.org/r/25430/diff/ > > > Testing > ------- > > Tested live migration on master using xenserver. > > > Thanks, > > bharat kumar > >
