----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24696/#review50572 -----------------------------------------------------------
test/integration/smoke/test_volumes.py <https://reviews.apache.org/r/24696/#comment88435> Just an additional refactor, we can do the check at the start before attach volume and skip, this reduces some time if these are not applicable for vmware and hyperv test/integration/smoke/test_volumes.py <https://reviews.apache.org/r/24696/#comment88436> This code was redundant in the same test case twice for both resize commands.May be we can refactor here as well, as such we have touched the test case. test/integration/smoke/test_volumes.py <https://reviews.apache.org/r/24696/#comment88437> My point was, what is the significance of this logic "if possible to shrink", start vm can still be possible with out previous if, so what check additionally we do if or if not for previous if? - Santhosh Edukulla On Aug. 14, 2014, 10:42 a.m., John Dilley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24696/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2014, 10:42 a.m.) > > > Review request for cloudstack and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-7228 > https://issues.apache.org/jira/browse/CLOUDSTACK-7228 > > > Repository: cloudstack-git > > > Description > ------- > > Currently only CLVM supports shrinking volumes. This patch will only attempt > to shrink a volume if CLVM is in use. > > > Diffs > ----- > > test/integration/smoke/test_volumes.py e2e0d76 > > Diff: https://reviews.apache.org/r/24696/diff/ > > > Testing > ------- > > Tested on XenServer to check that the test now passes. > > > Thanks, > > John Dilley > >
