----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24696/#review50570 -----------------------------------------------------------
test/integration/smoke/test_volumes.py <https://reviews.apache.org/r/24696/#comment88433> Test case pass\fail depends upon the previous if, then it will pass even with out going to the previous if? As well, the test case in itself is not clear as what we are trying to achieve? - Santhosh Edukulla On Aug. 14, 2014, 10:42 a.m., John Dilley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24696/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2014, 10:42 a.m.) > > > Review request for cloudstack and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-7228 > https://issues.apache.org/jira/browse/CLOUDSTACK-7228 > > > Repository: cloudstack-git > > > Description > ------- > > Currently only CLVM supports shrinking volumes. This patch will only attempt > to shrink a volume if CLVM is in use. > > > Diffs > ----- > > test/integration/smoke/test_volumes.py e2e0d76 > > Diff: https://reviews.apache.org/r/24696/diff/ > > > Testing > ------- > > Tested on XenServer to check that the test now passes. > > > Thanks, > > John Dilley > >
