-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22927/#review46973
-----------------------------------------------------------


Unable to apply the patch on latest master. 
can you rebase it to latest master and post it for review.




Applying: Forced timeout is not required. The default timeout value of 30 
minutes will suffice. Removed timeout in order to support login for Netscaler 
10.5 devices.
/home/rajesh/hyperv/.git/rebase-apply/patch:23: trailing whitespace.
                _netscalerService.set_credential(_username, _password);
error: patch failed: 
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java:293
error: 
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java:
 patch does not apply
Patch failed at 0001 Forced timeout is not required. The default timeout value 
of 30 minutes will suffice. Removed timeout in order to support login for 
Netscaler 10.5 devices.


- Rajesh Battala


On June 24, 2014, 10:23 a.m., Sujaya Maiyya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22927/
> -----------------------------------------------------------
> 
> (Updated June 24, 2014, 10:23 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6261
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6261
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The NetScaler Resource forces a idle timeout of 100,000 seconds during login. 
> It is best to leave it to the system default which is 30 mins. The timeout 
> has been removed from NetscalerResource in order to support login for 
> Netscaler 10.5 devices.
> 
> 
> Diffs
> -----
> 
>   
> plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java
>  54e5d50 
> 
> Diff: https://reviews.apache.org/r/22927/diff/
> 
> 
> Testing
> -------
> 
> Timeout was removed and login to the Netscaler devices with the default 
> timeout of 30 minutes was successful. It was tested for Netscaler builds 10.1 
> and 10.5.
> 
> 
> Thanks,
> 
> Sujaya Maiyya
> 
>

Reply via email to