> On June 30, 2014, 11:35 a.m., Rajesh Battala wrote:
> > plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java,
> >  line 2774
> > <https://reviews.apache.org/r/22927/diff/1/?file=615629#file615629line2774>
> >
> >     Remove the timeout from this method also
> >     This fix should have thrown compilation error as the variable not found.
> >     
> >     After fixing it Please build the code and post it for review.
> >

This timeout value is dfferent.
Patch looks fine. 
I will apply and push it.


- Rajesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22927/#review46970
-----------------------------------------------------------


On June 24, 2014, 10:23 a.m., Sujaya Maiyya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22927/
> -----------------------------------------------------------
> 
> (Updated June 24, 2014, 10:23 a.m.)
> 
> 
> Review request for cloudstack, Murali Reddy and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6261
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6261
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The NetScaler Resource forces a idle timeout of 100,000 seconds during login. 
> It is best to leave it to the system default which is 30 mins. The timeout 
> has been removed from NetscalerResource in order to support login for 
> Netscaler 10.5 devices.
> 
> 
> Diffs
> -----
> 
>   
> plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java
>  54e5d50 
> 
> Diff: https://reviews.apache.org/r/22927/diff/
> 
> 
> Testing
> -------
> 
> Timeout was removed and login to the Netscaler devices with the default 
> timeout of 30 minutes was successful. It was tested for Netscaler builds 10.1 
> and 10.5.
> 
> 
> Thanks,
> 
> Sujaya Maiyya
> 
>

Reply via email to