sure mike :) thanks.
On Tue, Jun 24, 2014 at 2:48 AM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22631/ > > Hi Punith, > > Just wanted to let you know that I have not forgotten about this review. > > I plan to check the code in once I finish up something else I'm working on > over the next day or so. > > Thanks! > Mike > > > - Mike Tutkowski > > On June 17th, 2014, 9:28 a.m. UTC, punith s wrote: > Review request for cloudstack, amit kumar das, edison su, and Mike > Tutkowski. > By punith s. > > *Updated June 17, 2014, 9:28 a.m.* > *Repository: * cloudstack-git > Description > > currently managed storage only supports iscsi protocol. > > hence now adding support for nfs protocol and also resizing the vdi to the SR > size, hence fully utilizing the SR space in managed storage. > > to support nfs, the getNfsSR method's signature has to changed similar to > existing getIscsiSR method. > > SR will be created based on the volume's protocoltype. > > jira id - CLOUDSTACK-6916 > > Testing > > system testing done. > > Diffs > > - api/src/com/cloud/agent/api/to/DiskTO.java (5901367) > - > engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java > (eea931e) > - > plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java > (9979802) > - server/src/com/cloud/storage/VolumeApiServiceImpl.java (9b034e9) > > View Diff <https://reviews.apache.org/r/22631/diff/> > -- regards, punith s cloudbyte.com