----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22454/#review45470 -----------------------------------------------------------
server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/22454/#comment80329> startIp is never null. There is a check in the caller to see if startIp is null. Even if this check exists here, it is of no use as it will fail with NPE in checkIpRange on the first line itself if the startip is null. server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/22454/#comment80331> Long.valueOf() gives you another Long. its basically converting Long to Long. We should do podId.longValue() to pass long. auto unboxing will take care it. - Rajani Karuturi On June 11, 2014, 9:18 a.m., Rajani Karuturi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22454/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 9:18 a.m.) > > > Review request for cloudstack, daan Hoogland, Koushik Das, and Santhosh > Edukulla. > > > Repository: cloudstack-git > > > Description > ------- > > unused assignments, boxing and unboxing of values etc. > > > Diffs > ----- > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 55736f9 > > Diff: https://reviews.apache.org/r/22454/diff/ > > > Testing > ------- > > > Thanks, > > Rajani Karuturi > >
