----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22454/#review45466 -----------------------------------------------------------
server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/22454/#comment80325> Based on the method checkIpRange(), startIp is mandatory but endIp is optional. Is all callers of checkPodAttributes enforcing that? server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/22454/#comment80324> Method signature is listByPodIdDcId(long, long). Parameter podId is of type Long, so it needs to be passed correctly. - Koushik Das On June 11, 2014, 9:18 a.m., Rajani Karuturi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22454/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 9:18 a.m.) > > > Review request for cloudstack, daan Hoogland, Koushik Das, and Santhosh > Edukulla. > > > Repository: cloudstack-git > > > Description > ------- > > unused assignments, boxing and unboxing of values etc. > > > Diffs > ----- > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 55736f9 > > Diff: https://reviews.apache.org/r/22454/diff/ > > > Testing > ------- > > > Thanks, > > Rajani Karuturi > >
