----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20316/#review40563 -----------------------------------------------------------
test/integration/component/test_ps_domain_limits.py <https://reviews.apache.org/r/20316/#comment73594> where is this func defined? I couldnt see it in current common mod? test/integration/component/test_ps_domain_limits.py <https://reviews.apache.org/r/20316/#comment73595> I believe codes and common module changes r missing test/integration/component/test_ps_domain_limits.py <https://reviews.apache.org/r/20316/#comment73585> Please call teardown in case of exception. test/integration/component/test_ps_domain_limits.py <https://reviews.apache.org/r/20316/#comment73588> Just check whether create is successful by verifying not None case and then add to clean up. test/integration/component/test_ps_domain_limits.py <https://reviews.apache.org/r/20316/#comment73584> Not calling teardown in case of exception. test/integration/component/test_ps_domain_limits.py <https://reviews.apache.org/r/20316/#comment73589> Its always 10, so may be we can remove this debug. test/integration/component/test_ps_domain_limits.py <https://reviews.apache.org/r/20316/#comment73590> We didnt added it to clean up. Is that ok? test/integration/component/test_ps_domain_limits.py <https://reviews.apache.org/r/20316/#comment73591> We are not adding it to cleanup? test/integration/component/test_ps_domain_limits.py <https://reviews.apache.org/r/20316/#comment73583> I believe the tag is selfservice, not simulator. test/integration/component/test_ps_domain_limits.py <https://reviews.apache.org/r/20316/#comment73593> Does clean up is not required here? test/integration/component/test_ps_domain_limits.py <https://reviews.apache.org/r/20316/#comment73592> We can remove typecasting to int here. test/integration/component/test_ps_resize_volume.py <https://reviews.apache.org/r/20316/#comment73586> Its not an issue though, just add one line of assert instead of if and fail, it may reduce few lines of code. - Santhosh Edukulla On April 14, 2014, 10:22 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20316/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 10:22 a.m.) > > > Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-1466 > https://issues.apache.org/jira/browse/CLOUDSTACK-1466 > > > Repository: cloudstack-git > > > Description > ------- > > Adding test suits in Primary Storage Limits test cases. > 1)Domain Limits > 2)Resize volume > > > Diffs > ----- > > test/integration/component/test_ps_domain_limits.py PRE-CREATION > test/integration/component/test_ps_resize_volume.py PRE-CREATION > > Diff: https://reviews.apache.org/r/20316/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Gaurav Aradhye > >
