> On April 16, 2014, 10:35 p.m., Santhosh Edukulla wrote: > > test/integration/component/test_ps_domain_limits.py, line 82 > > <https://reviews.apache.org/r/20316/diff/1/?file=556038#file556038line82> > > > > Please call teardown in case of exception.
I didn't call in this case because there will be nothing to cleanup in case of exception. We are adding only service offering to cleanup list and if there is exception, it means the service offering is not created and we don't have to do any cleanup. > On April 16, 2014, 10:35 p.m., Santhosh Edukulla wrote: > > test/integration/component/test_ps_domain_limits.py, line 106 > > <https://reviews.apache.org/r/20316/diff/1/?file=556038#file556038line106> > > > > Not calling teardown in case of exception. self.fail will execute tearDown and tearDownClass. > On April 16, 2014, 10:35 p.m., Santhosh Edukulla wrote: > > test/integration/component/test_ps_domain_limits.py, line 269 > > <https://reviews.apache.org/r/20316/diff/1/?file=556038#file556038line269> > > > > We didnt added it to clean up. Is that ok? VM will be cleaned up as part of account cleanup. No need to add it explicitly to cleanup list. > On April 16, 2014, 10:35 p.m., Santhosh Edukulla wrote: > > test/integration/component/test_ps_domain_limits.py, line 357 > > <https://reviews.apache.org/r/20316/diff/1/?file=556038#file556038line357> > > > > We are not adding it to cleanup? Are you pointing to VM? As above explained, no need to add it to cleanup. > On April 16, 2014, 10:35 p.m., Santhosh Edukulla wrote: > > test/integration/component/test_ps_domain_limits.py, line 559 > > <https://reviews.apache.org/r/20316/diff/1/?file=556038#file556038line559> > > > > Does clean up is not required here? it is cleaned up as part of Account/project cleanup. Here we are cleaning up the account, so nned to add volume expicitly to cleanup list. Same applies for VM. - Gaurav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20316/#review40563 ----------------------------------------------------------- On April 14, 2014, 3:52 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20316/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 3:52 p.m.) > > > Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-1466 > https://issues.apache.org/jira/browse/CLOUDSTACK-1466 > > > Repository: cloudstack-git > > > Description > ------- > > Adding test suits in Primary Storage Limits test cases. > 1)Domain Limits > 2)Resize volume > > > Diffs > ----- > > test/integration/component/test_ps_domain_limits.py PRE-CREATION > test/integration/component/test_ps_resize_volume.py PRE-CREATION > > Diff: https://reviews.apache.org/r/20316/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Gaurav Aradhye > >
