> On April 15, 2014, 5:11 a.m., Rajani Karuturi wrote: > > utils/src/com/cloud/utils/servlet/CacheControlUtil.java, line 24 > > <https://reviews.apache.org/r/20343/diff/1/?file=557372#file557372line24> > > > > Hi Laszlo, > > Is there any reason to disable browser caching for IE? > > I think we should just remove the t param for all the js files and let > > browsers cache them.
Hi Rajani, I will check that again but I believe IE might be the reason why that t param is there. Actually I have ran into a couple of situations in other projects where IE did not send another request for the resource when only sending Last-Modified and ETag headers, so these resources remained outdated after page refresh. - Laszlo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20343/#review40348 ----------------------------------------------------------- On April 15, 2014, 6:13 a.m., Laszlo Hornyak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20343/ > ----------------------------------------------------------- > > (Updated April 15, 2014, 6:13 a.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > - use the User-Agent header to get the client type > - only use the cache workaround if the browser is MSIE, use standard cache > control headers anyway > > > Diffs > ----- > > ui/index.jsp 5840e71 > utils/pom.xml cc6de3b > utils/src/com/cloud/utils/servlet/CacheControlUtil.java PRE-CREATION > utils/test/com/cloud/utils/servlet/CacheControlUtilTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/20343/diff/ > > > Testing > ------- > > -unit testing > -tests with firefox > - tests with IE > - tests with modified files > > > Thanks, > > Laszlo Hornyak > >
