----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20343/#review40348 -----------------------------------------------------------
utils/src/com/cloud/utils/servlet/CacheControlUtil.java <https://reviews.apache.org/r/20343/#comment73350> Hi Laszlo, Is there any reason to disable browser caching for IE? I think we should just remove the t param for all the js files and let browsers cache them. - Rajani Karuturi On April 14, 2014, 10:19 p.m., Laszlo Hornyak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20343/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 10:19 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > - use the User-Agent header to get the client type > - only use the cache workaround if the browser is MSIE, use standard cache > control headers anyway > > > Diffs > ----- > > ui/index.jsp 5840e71 > utils/pom.xml cc6de3b > utils/src/com/cloud/utils/servlet/CacheControlUtil.java PRE-CREATION > utils/test/com/cloud/utils/servlet/CacheControlUtilTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/20343/diff/ > > > Testing > ------- > > -unit testing > -tests with firefox > > TODO: > - tests with IE > - tests with modified files > > > Thanks, > > Laszlo Hornyak > >
