> On March 14, 2014, 12:14 p.m., Damodar Reddy Talakanti wrote: > > Hi Daan > > > > I have updated the FS in wiki regarding how to build and install using this > > code. The link to FS is > > > > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+Windowsfication#CloudstackWindowsfication-Installer > >
Hi Damodar, Other reviews may differ in opinion, but IMHO manual setup steps have to be documented precisely and in a form that other contributors can improve. An excellent example is at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Setting+up+a+CloudStack+dev+environment+on+Windows An example of where this level of detail is required is the "Seed SystemTemplate". WRT testing, if would be highly unusual to claim Windows 2k12 R2 support without having tried it in that environment. Have you tried reaching to the community for help verify your install steps on a Win2K12 R2? WRT accepting the code in this review, why not narrow the scope of the submission. The code above seems only to relate to Windows install for the management server, but the title implies that all details of Windows support will be covered. Rather than commit a half-finished feature, why not break windowsfication into a series of narrowly defined features. You can then make incremental submissions. DL - Donal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/#review37192 ----------------------------------------------------------- On March 14, 2014, 12:10 p.m., Damodar Reddy Talakanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18964/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 12:10 p.m.) > > > Review request for cloudstack, Abhinandan Prateek, Chiradeep Vittal, daan > Hoogland, and Donal Lafferty. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105 > > > Repository: cloudstack-git > > > Description > ------- > > Windowsfication of CloudStack Management Server > > > Diffs > ----- > > scripts/installer/windows/acs.wxs PRE-CREATION > scripts/installer/windows/client.wxs PRE-CREATION > scripts/installer/windows/start.bat PRE-CREATION > scripts/vm/systemvm/injectkeys.py PRE-CREATION > server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 > > Diff: https://reviews.apache.org/r/18964/diff/ > > > Testing > ------- > > Tested in Linux environment after changes > Also tested in Windows environment(For now tested on windows-8) to make sure > it is getting installed and management service is running. > > Able to add zones, able to register templates, able to launch a VM when it is > running on windows. > > Currently though it is getting added as a windows service, not able to start > the service through windows service control manager which I am looking into > currently. When run .exe file which is installed then server is getting up > and able to access cloud stack UI. > > For now The following assumptions are made: > 1. SSH keys are already installed > 2. JAVA is already installed > 3. tomcat is already installed > > This patch contains the following new files related to WiX tool (To compile > and run we need this tool) > 1. acs.wxs > The following command will be used to compile > "<Path To WiX Tool>\bin\candle.exe" acs.wxs > 2. client.wxs > The following command will be used to generate the above file > "<Path To WiX Tool>\bin\heat" dir client -gg -cg Test -ke -sfrag > -template fragment -out client.wxs -var wix.SourceClient -dr WEBAPPS > The following command will be used to compile the above generated file > "<Path To WiX Tool>\bin\candle.exe" client.wxs > 3. The following command will be used to generate .msi file > "<Path To WiX Tool>\bin\light.exe" acs.wixobj client.wixobj -out > acs.msi -ext "C:\Program Files (x86)\WiX Toolset > v3.8\bin\WixUIExtension.dll" -dSourceClient=SourceDir\client > > > Thanks, > > Damodar Reddy Talakanti > >
