> On March 14, 2014, 9:58 a.m., daan Hoogland wrote: > > server/src/com/cloud/server/ConfigurationServerImpl.java, line 881 > > <https://reviews.apache.org/r/18964/diff/3/?file=519572#file519572line881> > > > > why is this condition needed if both the if and the else branch take > > the same action.
For windows we are callin "PYTHON" script for others we are calling "SHELL" script that is why the if else branch there. > On March 14, 2014, 9:58 a.m., daan Hoogland wrote: > > server/src/com/cloud/server/ConfigurationServerImpl.java, line 740 > > <https://reviews.apache.org/r/18964/diff/3/?file=519572#file519572line740> > > > > as the test is for "windows" all the time, a var named isWindows or > > onWindows may be in order. > > Also mocked tests to show that the right paths are taken would be nice. Actually I am using static method from System.java so I do not think mock will allow to mock a static method. - Damodar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18964/#review37186 ----------------------------------------------------------- On March 14, 2014, 12:10 p.m., Damodar Reddy Talakanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18964/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 12:10 p.m.) > > > Review request for cloudstack, Abhinandan Prateek, Chiradeep Vittal, daan > Hoogland, and Donal Lafferty. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105 > > > Repository: cloudstack-git > > > Description > ------- > > Windowsfication of CloudStack Management Server > > > Diffs > ----- > > scripts/installer/windows/acs.wxs PRE-CREATION > scripts/installer/windows/client.wxs PRE-CREATION > scripts/installer/windows/start.bat PRE-CREATION > scripts/vm/systemvm/injectkeys.py PRE-CREATION > server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 > > Diff: https://reviews.apache.org/r/18964/diff/ > > > Testing > ------- > > Tested in Linux environment after changes > Also tested in Windows environment(For now tested on windows-8) to make sure > it is getting installed and management service is running. > > Able to add zones, able to register templates, able to launch a VM when it is > running on windows. > > Currently though it is getting added as a windows service, not able to start > the service through windows service control manager which I am looking into > currently. When run .exe file which is installed then server is getting up > and able to access cloud stack UI. > > For now The following assumptions are made: > 1. SSH keys are already installed > 2. JAVA is already installed > 3. tomcat is already installed > > This patch contains the following new files related to WiX tool (To compile > and run we need this tool) > 1. acs.wxs > The following command will be used to compile > "<Path To WiX Tool>\bin\candle.exe" acs.wxs > 2. client.wxs > The following command will be used to generate the above file > "<Path To WiX Tool>\bin\heat" dir client -gg -cg Test -ke -sfrag > -template fragment -out client.wxs -var wix.SourceClient -dr WEBAPPS > The following command will be used to compile the above generated file > "<Path To WiX Tool>\bin\candle.exe" client.wxs > 3. The following command will be used to generate .msi file > "<Path To WiX Tool>\bin\light.exe" acs.wixobj client.wixobj -out > acs.msi -ext "C:\Program Files (x86)\WiX Toolset > v3.8\bin\WixUIExtension.dll" -dSourceClient=SourceDir\client > > > Thanks, > > Damodar Reddy Talakanti > >
