> On March 3, 2014, 12:37 p.m., Santhosh Edukulla wrote: > > setup/db/hypervisors.simulator.sql, line 20 > > <https://reviews.apache.org/r/18679/diff/1/?file=507934#file507934line20> > > > > Id seems to be auto increment values, we can leave it by default, by > > chance if we have a row with id 22, then this insert will fail. > > > > I believe there is no constraint on uuid for simulator, it can be any > > varchar?
will change the query to INSERT INTO `cloud`.`hypervisor_capabilities` (`uuid`, `hypervisor_type`, `hypervisor_version`) values (uuid(), 'Simulator', 'default'); and update the patch - Rajani ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18679/#review35956 ----------------------------------------------------------- On March 3, 2014, 11:22 a.m., Rajani Karuturi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18679/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 11:22 a.m.) > > > Review request for cloudstack, Abhinandan Prateek, Koushik Das, Santhosh > Edukulla, and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > added a row for simulator in the hypervisor_capabilities. This will be > run only when deploydb-sumulator is called > This fixes some of the attach volume test cases when run against > simulator. > > > Diffs > ----- > > developer/pom.xml 5996de7 > setup/db/hypervisors.simulator.sql PRE-CREATION > > Diff: https://reviews.apache.org/r/18679/diff/ > > > Testing > ------- > > tested by running attach volume tests against simulator > > > Thanks, > > Rajani Karuturi > >
