----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18679/#review35956 -----------------------------------------------------------
setup/db/hypervisors.simulator.sql <https://reviews.apache.org/r/18679/#comment66758> All values seems to be default values except id,uuid etc. We can leave default values as it is rather setting them explicitly. This way, if these default values gets changed in future, the values will be set accordingly instead of user provided values. If we want user provided values for this, then we can explicitly specify setup/db/hypervisors.simulator.sql <https://reviews.apache.org/r/18679/#comment66759> Id seems to be auto increment values, we can leave it by default, by chance if we have a row with id 22, then this insert will fail. I believe there is no constraint on uuid for simulator, it can be any varchar? - Santhosh Edukulla On March 3, 2014, 11:22 a.m., Rajani Karuturi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18679/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 11:22 a.m.) > > > Review request for cloudstack, Abhinandan Prateek, Koushik Das, Santhosh > Edukulla, and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > added a row for simulator in the hypervisor_capabilities. This will be > run only when deploydb-sumulator is called > This fixes some of the attach volume test cases when run against > simulator. > > > Diffs > ----- > > developer/pom.xml 5996de7 > setup/db/hypervisors.simulator.sql PRE-CREATION > > Diff: https://reviews.apache.org/r/18679/diff/ > > > Testing > ------- > > tested by running attach volume tests against simulator > > > Thanks, > > Rajani Karuturi > >
