Miguel, here is my patch that for me fixed the dependency problems. Other
than that, it looks good.
Thank you,
Laszlo
On Fri, Feb 21, 2014 at 7:54 PM, Laszlo Hornyak <laszlo.horn...@gmail.com>wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18358/
>
> Hi Miguel,
>
> I started working on verification and I ran into some dependency problem.
> hamcrest-library is needed as dependency and junit 4.10 needs to be upgraded
> to 4.11
>
>
>
> - Laszlo Hornyak
>
> On February 21st, 2014, 4:43 p.m. UTC, Miguel Ferreira wrote:
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
> By Miguel Ferreira.
>
> *Updated Feb. 21, 2014, 4:43 p.m.*
> *Repository: * cloudstack-git
> Description
>
> - Refactor tests:
> - Upgrade tests to use jUnit4
> - Break big tests in small unit tests
> - Replace assertTrue/False with complex conditions by assertThat with
> specific matchers
> - Remove dead code:
> - Private static method never called locally
> - Add test for method that validates CIDRs
>
> Testing
>
> Ran all the tests in the test class before and after refactoring.
>
> Diffs
>
> - utils/src/com/cloud/utils/net/NetUtils.java (c22e39a)
> - utils/test/com/cloud/utils/net/NetUtilsTest.java (d3e283c)
>
> View Diff <https://reviews.apache.org/r/18358/diff/>
>
--
EOF
From 728239ddabef9b9775df74df47fd58a117e1515a Mon Sep 17 00:00:00 2001
From: Laszlo Hornyak <laszlo.horn...@gmail.com>
Date: Fri, 21 Feb 2014 19:58:12 +0100
Subject: [PATCH 2/2] Fixes for 1c4bf5f163bd721daa0b53e3d43d3de13a3b05d9
- upgraded junit to 4.11
- added hamcrest-library 1.3 dependency, test are building on it
Signed-off-by: Laszlo Hornyak <laszlo.horn...@gmail.com>
---
pom.xml | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/pom.xml b/pom.xml
index 1e9e8d8..4532679 100644
--- a/pom.xml
+++ b/pom.xml
@@ -49,7 +49,8 @@
<cs.logging.version>1.1.1</cs.logging.version>
<cs.discovery.version>0.5</cs.discovery.version>
<cs.ejb.version>3.0</cs.ejb.version>
- <cs.junit.version>4.10</cs.junit.version>
+ <!-- do not forget to also upgrade hamcrest library with junit -->
+ <cs.junit.version>4.11</cs.junit.version>
<cs.bcprov.version>1.46</cs.bcprov.version>
<cs.jsch.version>0.1.42</cs.jsch.version>
<cs.jpa.version>2.0.0</cs.jpa.version>
@@ -414,6 +415,12 @@
<scope>test</scope>
</dependency>
<dependency>
+ <groupId>org.hamcrest</groupId>
+ <artifactId>hamcrest-library</artifactId>
+ <version>1.3</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-all</artifactId>
<version>1.9.5</version>
--
1.8.3.1
